Use GlobalTransform #177
Closed
Use GlobalTransform #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shatur
force-pushed
the
use-global-transform
branch
from
ddfe164
to
80dd8fb
Compare
Shatur
force-pushed
the
use-global-transform
branch
from
80dd8fb
to
3218da9
Compare
|
Thank you for this PR! The transform writeback formulae is slightly incorrect (the translation part should take the parent’s rotation into account). In addition, I see that instead of querying the parent’s global transform, you recover it from the child global transform and transform. While this is a good idea to avoid a query, it will break the transform change detection we do in I have a fix ready for these, it it appears that I don’t have the access right to push to your branch. Could you please enable edits from maintainers? |
|
@sebcrozet for unknown reason I don't see such button: Maybe you can just create another PR based on my? |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
GlobalTransforminstead ofTransformto place colliders correctly and added a test for it. I also had to addGlobalTransformto all examples.