Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove CUDA support relying on abandoned toolchain #1333

Merged
merged 1 commit into from
Jan 12, 2024
Merged

Remove CUDA support relying on abandoned toolchain #1333

merged 1 commit into from
Jan 12, 2024

Conversation

Ralith
Copy link
Collaborator

@Ralith Ralith commented Dec 16, 2023 •
edited
Loading

Fixes #1330. Required to get CI green again. This is a breaking change.

@tpdickso tpdickso mentioned this pull request Dec 24, 2023
Open
tpdickso
tpdickso approved these changes Jan 12, 2024
View reviewed changes
Copy link
Collaborator

@tpdickso tpdickso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably should wait for a more tenured maintainer to approve before merging this, but leaving my approval here to mark that I looked over the code here and it looks correct to me.

@Ralith
Copy link
Collaborator Author

Ralith commented Jan 12, 2024

Meh, CI is broken and sebcrozet's already approved the idea. Let's get green.

@Ralith Ralith merged commit 7866bce into dimforge:dev Jan 12, 2024
11 checks passed
@Ralith Ralith deleted the no-cuda branch January 12, 2024 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tpdickso tpdickso tpdickso approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CUDA target is unmaintained
2 participants
@Ralith @tpdickso