Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: Update indexmap from 1 to 2 #158

Merged
merged 1 commit into from
Jun 23, 2024

Conversation

waywardmonkeys
Copy link
Contributor

This is only used when enhanced-determinism is enabled.

@waywardmonkeys
Copy link
Contributor Author

There's an interesting detail here in that even before this, the tests fail for cargo test --features enhanced-determinism,serde-serialize ... but they fail same way with and without this update. (Should probably file a bug about that test failure...)

@waywardmonkeys
Copy link
Contributor Author

This fails for the cuda build as that uses a set version of the nightly from 2021 and hashbrown, a dependency of indexmap has an MSRV of 1.64.

It feels like this will become an increasingly common issue as many crates are ramping up their MSRV to more recent versions than the old nightly that Cuda support requires.

@waywardmonkeys
Copy link
Contributor Author

@sebcrozet I've rebased this forward and fixed the merge conflicts.

This is only used when `enhanced-determinism` is enabled.
@sebcrozet sebcrozet merged commit c82502c into dimforge:master Jun 23, 2024
5 checks passed
@sebcrozet
Copy link
Member

Fantastic, thanks!

@waywardmonkeys waywardmonkeys deleted the update-dep-indexmap branch June 24, 2024 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants