-
-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplified mesh intersection logic #221
Merged
sebcrozet
merged 48 commits into
dimforge:master
from
Makogan:improve_mesh_intersection_code
Jul 17, 2024
Merged
Changes from 24 commits
Commits
Show all changes
48 commits
Select commit
Hold shift + click to select a range
598dda9
WIP simplified mesh interseciton logic
39f026d
Make mesh intersection code more robust
1781d71
Fixed logic errors and addet tests
7a1d967
add test data
c6e3adf
Hide wavefront functionality behind a feature flag
008517e
Merge remote-tracking branch 'origin/master' into improve_mesh_inters…
9a7b87a
Fix compilation errors
130d5f2
Fix CI
20502c5
Fix CI issues
b061752
Delete unused code
592455d
Simplift feature flag
4c7e50b
Fix PR comments
00577c5
Fix clippy issue
fdd2919
Remove accidental pastes
8416d1f
Fix compilation in no-std
fe57b27
Fix clippy
b001cc5
Fix Clippy
97c2b6c
Fix clippy
998dfcc
Address new PR comments
f8d272d
Make clippy happy
ff83f9d
Replace glob import with explicit items
a79b65a
Replace unwrap with error checking
5a1a187
Fix bug when finding smallest triangle angle
b155fbf
Fix spelling
e93a2cd
Update src/transformation/mesh_intersection/mesh_intersection.rs
Makogan 9a227fb
Update src/shape/triangle.rs
Makogan 0a18f4c
Update src/shape/triangle.rs
Makogan 5b24476
Update src/transformation/mesh_intersection/mesh_intersection.rs
Makogan 5d06a91
Update src/transformation/mesh_intersection/mesh_intersection.rs
Makogan d870f38
Update src/transformation/mesh_intersection/mesh_intersection.rs
Makogan cad8511
Update src/transformation/mesh_intersection/mesh_intersection.rs
Makogan 5b20345
Update src/transformation/mesh_intersection/mesh_intersection.rs
Makogan 2dd4e03
Update src/transformation/mesh_intersection/mesh_intersection.rs
Makogan a1e7f79
Update src/transformation/mesh_intersection/mesh_intersection.rs
Makogan 0a19454
Update src/transformation/mesh_intersection/mesh_intersection.rs
Makogan 46b1c75
Update src/transformation/mesh_intersection/mesh_intersection.rs
Makogan 08038a0
Update src/transformation/mesh_intersection/mesh_intersection.rs
Makogan c514027
Update src/transformation/mesh_intersection/mesh_intersection.rs
Makogan 773b949
Update comment
7501a0b
Merge branch 'improve_mesh_intersection_code' of https://github.com/M…
8193b70
Fix formatting
56856d0
chore: move test assets to assets/tests
sebcrozet e888e0d
chore: move angle_closest_to_90 as a method of Triangle
sebcrozet bb9447d
fix: re-add sanitization of spade point coordinates
sebcrozet fce4c30
chore: minor coding style fixes
sebcrozet 1f5217a
chore: update changelog
sebcrozet 0fc0e89
Merge remote-tracking branch 'origin/master' into improve_mesh_inters…
sebcrozet 24b8b93
chore: more changelog update
sebcrozet File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I’d rather have it in
triangle.rs
and private since that’s the only place it’s used.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is also used in the mesh intersection code inside of
triangulate_constraints_and_merge_duplicates
, line 407. That's why i had to move it there. So that I had access to it.