Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recipe override should be able to set type #46

Closed
dabrahams opened this issue Nov 29, 2010 · 3 comments
Closed

Recipe override should be able to set type #46

dabrahams opened this issue Nov 29, 2010 · 3 comments

Comments

@dabrahams
Copy link
Contributor

Great. Seems to me that recipe override might easily need to set the type. For example, if I fork some cvs-based package to github and make some modifications that haven't been accepted upstream yet, I want to change the type and the URL, and nothing else. In fact, I'm pretty sure that's about to happen for me with wanderlust, in fact.

@dimitri
Copy link
Owner

dimitri commented Nov 29, 2010

Well, how do you tell apart a merge situation against a local-only (I mean embedded into el-get-sources) definition then?

Also, please remember that you have el-get-recipe-path to tweak to your content. The first recipe file found in this paths list will get used, no other. That seems to be the lever you're looking here.

@dabrahams
Copy link
Contributor Author

Well, how do you tell apart a merge situation against a local-only (I mean embedded into el-get-sources) definition then?

By a different mechanism, naturally. I suggest deprecating the no-type mechanism (I don't mean removing support today, just put users on notice) and allow an :inherit t keyword to indicate an override.

Also, please remember that you have el-get-recipe-path to tweak to your content. The first recipe file found in this paths list will get used, no other.

If none other will be used, what do you mean by

If your property list is missing the :type property, then it's
merged with the recipe one, so that you can override any
definition provided by `el-get' recipes locally.

oh... maybe you mean that overrides only work for property lists in el-get-sources, but if I have a recipe, it can't override bits of other recipes?

@dimitri
Copy link
Owner

dimitri commented Nov 30, 2010

Exactly, that's what we have now.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants