Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for PostgreSQL 9.2 #4

Closed
cmaloney opened this issue Sep 21, 2012 · 6 comments
Closed

Support for PostgreSQL 9.2 #4

cmaloney opened this issue Sep 21, 2012 · 6 comments

Comments

@cmaloney
Copy link

Prefix doesn't support being built against/support postgresql 9.2:

$cd prefix
$make
gcc -march=x86-64 -mtune=generic -O2 -pipe -fstack-protector --param=ssp-buffer-size=4 -D_FORTIFY_SOURCE=2 -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Wendif-labels -Wmissing-format-attribute -Wformat-security -fno-strict-aliasing -fwrapv -fexcess-precision=standard -fpic -DPREFIX_PGVER=902 -I. -I. -I/usr/include/postgresql/server -I/usr/include/postgresql/internal -D_GNU_SOURCE -I/usr/include/libxml2 -c -o prefix.o prefix.c
prefix.c:62:2: error: #error "Unknown or unsupported postgresql version"
prefix.c: In function ‘pr_presort’:
prefix.c:1435:15: warning: variable ‘maxlen’ set but not used [-Wunused-but-set-variable]
prefix.c: In function ‘gpr_union’:
prefix.c:1868:31: warning: variable ‘old’ set but not used [-Wunused-but-set-variable]
make: *** [prefix.o] Error 1

@dimitri
Copy link
Owner

dimitri commented Sep 24, 2012

I'll look into that shortly, usually all it needs is a #if change. I'm wondering if I should try to make prefix_range a proper RANGE type in 9.2, though.

@vazir
Copy link

vazir commented Oct 12, 2012

Hi Dmitri, any hope to have it compiling for 9.2 ?

@cmaloney
Copy link
Author

I actually looked into the ifdef and it does compile fully if you just add a case for the new postgres version to the version check ifdedf. I haven't run the test suite/tried using it after doing this however.

@vazir
Copy link

vazir commented Oct 12, 2012

Yea, adding
&& PG_MAJOR_VERSION != 901 && PG_MAJOR_VERSION != 902
helps
I was hoping Dmitri will be able to update debian build rules to have it making 9.2 package, as despite I did update necessary section, it still builds 9.1

@dimitri
Copy link
Owner

dimitri commented Oct 15, 2012

I've fixed the code to build properly on 9.2 and current 9.3 development version, and included a long time fix (sorry about the maintenance delay here). Working next on building debian packages and updates for 9.1 and 9.2.

@dimitri dimitri closed this as completed Oct 15, 2012
@vazir
Copy link

vazir commented Oct 17, 2012

Cool! Thanks so much Dmitri!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants