Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include the css in the bundle #57

Closed
DrGor opened this issue May 14, 2021 · 1 comment
Closed

Include the css in the bundle #57

DrGor opened this issue May 14, 2021 · 1 comment

Comments

@DrGor
Copy link

DrGor commented May 14, 2021

First of all thank you for the library.

Usually, if you are sure that your average user won't need to override your styles, then the styles can be a part of the bundle.
For this project, the css names are tightly coupled with the implementation.
Is there a specific reason why the average user must import the css manually?

@DrGor DrGor changed the title Include the css in the budnle Include the css in the bundle May 14, 2021
@DimitryDushkin
Copy link
Owner

Hey! You're absolutely right.
I've done it in such a way just because it was the simplest way to do it back then when I first opened this solution. Nowadays, I prefer CSS-in-JS or CSS modules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants