offsetWidth and offsetHeight always 0 when using bLazy in ajax request.

[shaughnlgh]

v1.2.2
The offsetWidth and offsetHeight always returns 0 when using bLazy in an ajax request.

I know that the offset values will return 0 when the element = display:none; however this is not the case.

Whats happening is the following:
line 130

"if(ele.offsetWidth > 0 && ele.offsetHeight > 0) {

If these values are 0, then the image preloader keep loading forever and the image element never gets updated with the actual source.

by removing line 130 and 156, i managed to resolve the issue and everything works as expected, however im not sure what this check is actually for or if it should even be there as there is no else statement allowing to update or notify that there was an issue.

Regards
Shaughn

[dinbror]

Hey SirMuppit.

Sorry for the really late reply. The check is there to ensure that we're not loading images that are hidden. When the offset values are 0 they're either hidden (display:none) or collapsed.

Do you have a live example I can see?

[shaughnlgh]

Hey

Ye, so i have patched it with my suggested fix and it seems to work well now. You can see a live example here: http://s.boardmans.fontera.com/shop-by-room/kitchen/category/storage/show/all.html

I have implemented your script into a working Magento Module that could be reused on other Magento sites.

Regards
Shaughn

On 23 Jul 2014, at 12:50 PM, dinbror notifications@github.com wrote:

Hey SirMuppit.

Sorry for the really late reply. The check is there to ensure that we're not loading images that are hidden. When the offset values are 0 they're either hidden (display:none) or collapsed.

Do you have a live example I can see?

—
Reply to this email directly or view it on GitHub.

[dinbror]

Hey,

because you removed the check all your images are getting both the error and success class added: "b-error b-loaded".

How do you load the images with ajax?

[shaughnlgh]

Hey, I’m not sure to be exact, i will need to setup a vanilla Magento store and check each instance. For now, close the bug and ill give more feedback and details on it as soon as i have a chance, since i can’t remember any of my finding’s lol.

I did notice the duplicate classes being added, but i will need to do a diff from you current version with the version i have now and see whats different.

Thanks for the reply, though. Much appreciated.

Regards
Shaughn

On 05 Aug 2014, at 2:41 PM, dinbror notifications@github.com wrote:

Hey,

because you removed the check all your images are getting both the error and success class added: "b-error b-loaded".

How do you load the images with ajax?

—
Reply to this email directly or view it on GitHub.