Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ruby 3.0 support #63

Closed
clarkedb opened this issue Feb 4, 2022 · 3 comments · Fixed by #64
Closed

Ruby 3.0 support #63

clarkedb opened this issue Feb 4, 2022 · 3 comments · Fixed by #64

Comments

@clarkedb
Copy link
Contributor

clarkedb commented Feb 4, 2022

Does the existing version (1.5.0) of postgres-copy work on Ruby 3.0? I didn't see anything in the docs confirming that it does. Also the CI only tests for ruby 2.7.

I would be happy to submit a PR to help if it needs work.

@diogob
Copy link
Owner

diogob commented Feb 5, 2022

Some tests seem to be failing in my local machine under 3.0. I did not investigate it further. If you are willing to put the time I'd be glad to help you merge the code.

@clarkedb
Copy link
Contributor Author

clarkedb commented Feb 6, 2022

Some tests seem to be failing in my local machine under 3.0. I did not investigate it further. If you are willing to put the time I'd be glad to help you merge the code.

I've submitted a PR (#64) which makes the necessary changes and also modifies the CI workflow to run against multiple ruby versions.

@diogob diogob closed this as completed in #64 Feb 7, 2022
@diogob
Copy link
Owner

diogob commented Feb 8, 2022

@clarkedb I have released version 1.6.0 with your changes merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants