Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parser appends on the wrong side of lists. #40

Open
Renelvon opened this issue Jul 12, 2014 · 0 comments
Open

Parser appends on the wrong side of lists. #40

Renelvon opened this issue Jul 12, 2014 · 0 comments

Comments

@Renelvon
Copy link
Collaborator

When reducing rules that result to lists or sequences, the parser currently appends elements at the start and not the end of lists. This is a possible performance issue.

Proposed fix: Make the parser append at the end of lists, but reverse the said lists just before embedding them inside the AST Nodes. This will maintain program order.

Accompany with appropriate unit tests demonstrating correctness of patch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant