Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OLD-2564: Use unique form names, no adminForm #75

Closed
cpaschen opened this issue Oct 21, 2012 · 2 comments
Closed

OLD-2564: Use unique form names, no adminForm #75

cpaschen opened this issue Oct 21, 2012 · 2 comments
Assignees

Comments

@cpaschen
Copy link
Member

Description

adminForm poses too many potential conflicts, so we should use unique form names

History

#12 Updated by Chris DioscouriChris Paschen. 8 months ago

Target version changed from Version 0.9.9 - Misc Bug Fixes and New Features to Version 0.9.3 - Admin Interface Cleanup

#11 Updated by Chris DioscouriChris Paschen. 8 months ago

Target version changed from Version 0.9.0 - Major Core Fixes to Version 0.9.9 - Misc Bug Fixes and New Features

#10 Updated by Chris DioscouriChris Paschen. 9 months ago

Priority changed from Normal to Low

#9 Updated by Chris DioscouriChris Paschen. 9 months ago

Assignee set to Lukas Polak
Target version changed from Version 0.9.9 - Misc Bug Fixes and New Features to Version 0.9.0 - Major Core Fixes
Affects Template Files set to No

Lukas - is this just refering to the class name?

Could we just replace all 'adminForm' occurrances with 'TiendaAdminForm'?

(using search/replace in aptana?)

Or am I missing something here?

#8 Updated by Chris DioscouriChris Paschen. about 1 year ago

Target version changed from Version 0.8.1 - Bug Fixes to Version 0.9.9 - Misc Bug Fixes and New Features

#7 Updated by Rafael Diaz-Tushman over 1 year ago

Target version changed from Version 0.6.3 - New Features and Bug Fixes to Version 0.8.1 - Bug Fixes

#6 Updated by Rafael Diaz-Tushman almost 2 years ago

Target version changed from Version 0.6.1 - New Features and Bug Fixes to Version 0.6.3 - New Features and Bug Fixes

#5 Updated by Rafael Diaz-Tushman almost 2 years ago

Target version changed from Version 0.6.0 - New Major Features and Bug Fixes to Version 0.6.1 - New Features and Bug Fixes

#4 Updated by Rafael Diaz-Tushman almost 2 years ago

Subject changed from Use unique form names to Use unique form names, no adminForm

#3 Updated by Rafael Diaz-Tushman about 2 years ago

Target version changed from Version 0.5.6 - New Minor Features and Bug Fixes to Version 0.6.0 - New Major Features and Bug Fixes

#2 Updated by Rafael Diaz-Tushman about 2 years ago

Target version changed from Version 0.5.5 - New Minor Features and Bug Fixes to Version 0.5.6 - New Minor Features and Bug Fixes

#1 Updated by Rafael Diaz-Tushman about 2 years ago

Target version changed from Version 0.5.4 - New Minor Features and Bug Fixes to Version 0.5.5 - New Minor Features and Bug Fixes

Associated revisions

Revision 839

Added by Rafael Diaz-Tushman about 2 years ago

Cleaned up default template
fixes #3158: Add to cart button in product listings
refs #2910: Content Plugin product_buy forms need to have unique names
refs #2564: Use unique form names

@ChrisFrench
Copy link
Member

Chris P, is this something we actually want to do anymore, I think we should probably leave them as adminForm and than follow the joomla 3.0 guidelines and add this .

Forms that have name="adminForm" now also require id="adminForm".

@ghost ghost assigned cpaschen Oct 25, 2012
@ChrisFrench
Copy link
Member

I am going to go with we leave adminForm, and than add the ID as well as joomla docs say to do. Closing this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants