Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature suggestion] Indicate used satellites on bar graph page #16

Closed
Olf0 opened this issue Jan 5, 2020 · 4 comments
Closed

[Feature suggestion] Indicate used satellites on bar graph page #16

Olf0 opened this issue Jan 5, 2020 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@Olf0
Copy link

Olf0 commented Jan 5, 2020

Please also indicate on the bar graph page, which satellites are currently in use, as it is already the case on the polar view page.
Preferably with the same way of indicating a satellite's use: a white outline around the coloured area (which depicts the satellite's signal strength).

The usefulness of this became apparent when trying to look further into the observation made in this side note.

@Olf0 Olf0 changed the title Indicate used satellites on bar graph page [Feature suggestion] Indicate used satellites on bar graph page Jan 5, 2020
@direc85
Copy link
Owner

direc85 commented Jan 5, 2020

Thanks for the report. I was actually planning to open this myself, this was already mentioned in issue #4

The issue is QChart.js, which doesn't offer a method to highlight a bar easily, so the options are patching QChart.js or reimplementing it. After seeing the performance boost my radar view rewrite had, I'm going to implement similar graph drawing method in QML.

@direc85 direc85 self-assigned this Jan 5, 2020
@direc85 direc85 added the enhancement New feature or request label Jan 5, 2020
@Olf0
Copy link
Author

Olf0 commented Jan 5, 2020

Thanks for the prompt and positive reply.

A second thought

Actually outlining the bars was a bad idea:

  • The outlines at the sides of the bar need additional horizontal space, thus reducing the width of the coloured part of the bars.
  • Outlines at the sides of the bars create the corner case of two adjacent bars being outlined: A double width outline might look ugly and occupies even more horizontal space.
  • An outline at the bottom of the bars is simply superfluous and may look weird.

So I think the top of the bars is the right spot to position an "in use" indicator.
Maybe a simple white "top line" is sufficient to achieve this easily.

@sbridger
Copy link

sbridger commented May 31, 2021

I have implemented this by changing bar colour: All active bars are the rssi color (like now) . inactive bars are all the same scale draw color.
I tried to use border color, width and label color, but they do nothing. Chart does appear to put fine lines in the grid color around the bars (visible when you make the bar color "transparent")

I have been wasting time after finding that when I delete your gpsinfo install, my version doesn't run because Chart is unknown. I have just found that pulling gpsinfo from GH does make the chart folder, but does not get any of the files inside it. However none of it is part of the project file, so I have no idea where Chart came from.

Do you need to add QChart to the project file?

@sbridger sbridger mentioned this issue Jun 1, 2021
@direc85
Copy link
Owner

direc85 commented Mar 20, 2022

This is now "implemented-enough" in an already released version, so this can be closed. I'm still going to rewrite the barchart page to do without the external chart element - much like what I did to the radar page - but it's outside this issue.

Closing as fixed :)

@direc85 direc85 closed this as completed Mar 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants