Silence prefer builtins and circular dependency warnings when buildin…

…g extensions (#18366) * Silence prefer builtins warning * Silence circular dependency warning if only external files are involved * Add changeset
directus · Apr 28, 2023 · 3ff71cc · 3ff71cc
1 parent 76ae228
commit 3ff71cc
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/.changeset/chilly-pugs-pay.md b/.changeset/chilly-pugs-pay.md
@@ -0,0 +1,5 @@
+---
+'@directus/extensions-sdk': patch
+---
+
+Silenced prefer builtins and circular dependency warnings when building extensions
diff --git a/packages/extensions-sdk/src/cli/commands/build.ts b/packages/extensions-sdk/src/cli/commands/build.ts
@@ -591,7 +591,7 @@ function getRollupOptions({
 			languages.includes('typescript') ? esbuild({ include: /\.tsx?$/, sourceMap: sourcemap }) : null,
 			mode === 'browser' ? styles() : null,
 			...plugins,
-			nodeResolve({ browser: mode === 'browser' }),
+			nodeResolve({ browser: mode === 'browser', preferBuiltins: mode === 'node' }),
 			commonjs({ esmExternals: mode === 'browser', sourceMap: sourcemap }),
 			json(),
 			replace({
@@ -602,6 +602,11 @@ function getRollupOptions({
 			}),
 			minify ? terser() : null,
 		],
+		onwarn(warning, warn) {
+			if (warning.code === 'CIRCULAR_DEPENDENCY' && warning.ids?.every((id) => /\bnode_modules\b/.test(id))) return;
+
+			warn(warning);
+		},
 	};
 }