Silence prefer builtins and circular dependency warnings when building extensions #18366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickrum
requested review from
a team,
paescuj,
rijkvanzanten and
jaads
and removed request for
a team
🦋 Changeset detectedLatest commit: 06eff53 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
nickrum
force-pushed
the
imp/extension-warnings-silence
branch
from
018d2ec
to
06eff53
Compare
rijkvanzanten
approved these changes
Apr 28, 2023
meditadvisors
pushed a commit
to ciso360ai/directus-mod
that referenced
this pull request
May 13, 2023
…g extensions (directus#18366) * Silence prefer builtins warning * Silence circular dependency warning if only external files are involved * Add changeset
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Those warnings come up when bundling API extensions. Circular dependency warnings are only silenced when only external files are involved. Unfortunately, the prefer builtins warning can't be disabled for external files only, enabling the option and thus silencing the warning should still be rasonably safe for API extensions as this is rollup's default.