Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cache poisoning with auto converted assets #18228

Closed
gbicou opened this issue Apr 18, 2023 · 0 comments · Fixed by #18229
Closed

Cache poisoning with auto converted assets #18228

gbicou opened this issue Apr 18, 2023 · 0 comments · Fixed by #18229

Comments

@gbicou
Copy link
Contributor

gbicou commented Apr 18, 2023

Describe the Bug

When using format=auto (thanks to #18012), the transformed asset is not cached according to the client Accept header.

This leads to cache poisoning between multiple image formats from different browsers.

To Reproduce

Request a asset with ?format=auto, the response only includes Vary: Origin.

Directus Version

v9.25.1

Hosting Strategy

Self-Hosted (Custom)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Vary on accept when auto converting assets (#18228) gbicou/directus
1 participant
@gbicou