Autoconvert assets if browser supports it #18012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nitwel
requested review from
paescuj,
licitdev and
azrikahar
and removed request for
a team
rijkvanzanten
requested changes
Apr 12, 2023
|
Updated it to a query option. |
The previous approach did not work because the format property was passed to sharp with the value "auto" and this is not a valid option
|
Added a quick & dirty (but so far successful) approach in 7922e1c to auto transform images within the app as per #16068 (comment). @Nitwel Could you verify if the idea of allowing the |
|
It doesn't make sense to allow for But you brought up a good point which is that I did forgot a presets implementation for assets. Added that now. |
|
Only a quick lint run 😅 and some testing but I'm happy where it's at right now. |
paescuj
reviewed
Apr 12, 2023
paescuj
reviewed
Apr 12, 2023
rijkvanzanten
approved these changes
Apr 12, 2023
hanneskuettner
pushed a commit
to hanneskuettner/directus
that referenced
this pull request
Apr 18, 2023
Co-authored-by: Pascal Jufer <pascal-jufer@bluewin.ch> Co-authored-by: Rijk van Zanten <rijkvanzanten@me.com>
meditadvisors
pushed a commit
to ciso360ai/directus-mod
that referenced
this pull request
May 13, 2023
Co-authored-by: Pascal Jufer <pascal-jufer@bluewin.ch> Co-authored-by: Rijk van Zanten <rijkvanzanten@me.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16068
Fixes ENG-157
Ref: #15918