Move the app entrypoints to the assets directory #10643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The app's main js entrypoint was in the assets directory before. I moved entrypoints one directory up to distinguish them from other chunks. This is now done by using a `.entry.js` extension for entrypoints. This also makes the shared dependency detection more robust.
nickrum
force-pushed
the
opt/app-entrypoints-assets
branch
from
da69584
to
10b39f5
Compare
rijkvanzanten
approved these changes
Dec 24, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The app's main js entrypoint was in the assets directory before. I moved entrypoints one directory up to distinguish them from other chunks. This is now done by using a
.entry.jsextension for entrypoints.This also makes the shared dependency detection more robust.