-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add strings to accepted fields for Insights Panel "Metrics" #10828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ghts-panel-extension
…ghts-panel-extension
…ghts-panel-extension
…ghts-panel-extension
@jaycammarano Is this still a (WIP) as the title suggests? |
jamescammarano
changed the title
Add strings to accepted fields for Insights Panel "Metrics" (WIP)
Add strings to accepted fields for Insights Panel "Metrics"
Jan 12, 2022
no |
…ghts-panel-extension
…ghts-panel-extension
…ghts-panel-extension
…ghts-panel-extension
…ghts-panel-extension
rijkvanzanten
requested changes
Feb 3, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll handle the review points 👍🏻
...ngs/routes/data-model/field-detail/field-detail-advanced/field-detail-advanced-interface.vue
Outdated
Show resolved
Hide resolved
.../modules/settings/routes/data-model/field-detail/field-detail-simple/field-configuration.vue
Outdated
Show resolved
Hide resolved
app/src/modules/settings/routes/data-model/field-detail/shared/extension-options.vue
Outdated
Show resolved
Hide resolved
app/src/modules/settings/routes/data-model/field-detail/shared/extension-options.vue
Outdated
Show resolved
Hide resolved
app/src/modules/settings/routes/data-model/field-detail/shared/extension-options.vue
Outdated
Show resolved
Hide resolved
rijkvanzanten
approved these changes
Feb 3, 2022
This was referenced Feb 6, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add strings to accepted fields for Insights Panel "Metrics"
Before this PR:
Now:
TODO:
Future-Proofing:
I added an optional property to the PanelConfig interface to allow a function that manipulates what the edits object contains. I pass the whole panel
edits
object to the panel frompanel-configuration
. This will allow future panels to use the alterOptions function to change more than just what fields are available.Preview: