Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix repeater's extension options not updating when configured #11453

Merged
merged 3 commits into from
Feb 9, 2022

Conversation

azrikahar
Copy link
Contributor

Fixes #11447

Investigation

The bug occurs due to extension options being null (as seen in the bug report errors). Seems like in #10828, @input was replaced with v-model here: https://github.com/directus/directus/pull/10828/files#diff-922856f7e4b8d662bef225e06b6c4f096632405eb04f56692933576ab202f3f7L20

However the list extension options emits input rather than update:modelValue as seen here:

Hence options are not being updated when configured.

Changes made

  • Replaced v-model="optionsValues" with @input="optionsValues = $event" to fix the reported issue..

  • Fixed lint warning for extensionInfo possibly undefined in :is="`${type}-options-${extensionInfo!.id}`". usesCustomComponent will only be true when extensionInfo has value.

  • Changed emitted update:model-value to camelCase update:modelValue just for consistency as the latter is used throughout the app.

@azrikahar azrikahar changed the title Issue/11447 Fix repeater's extension options not updating when configured Feb 6, 2022
@abdonrd
Copy link
Contributor

abdonrd commented Feb 6, 2022

Thanks! 👏

@azrikahar azrikahar self-assigned this Feb 7, 2022
@azrikahar azrikahar mentioned this pull request Feb 7, 2022
3 tasks
@rashidpathiyil
Copy link

Thank you ❤️
Waiting for this fix.🚀

@rijkvanzanten rijkvanzanten added this to the v9-next milestone Feb 9, 2022
@rijkvanzanten rijkvanzanten merged commit f4275b4 into main Feb 9, 2022
@rijkvanzanten rijkvanzanten deleted the issue/11447 branch February 9, 2022 16:04
@rashidpathiyil
Copy link

How to install beta version of Directus@next to get the fix instantly ?

@rijkvanzanten
Copy link
Member

@rashidpathiyil You could build the repo from source (https://docs.directus.io/contributing/running-locally/), but I would highly suggest either sticking on the previous version that didn't have this bug, or waiting until the full release 👍🏻

@rashidpathiyil
Copy link

rashidpathiyil commented Feb 10, 2022

I can't go back to previous version due to cockroachdb bug #11266

so I am waiting....

@azrikahar azrikahar mentioned this pull request Feb 12, 2022
3 tasks
@thepurpleblob
Copy link

This is a bit of a show-stopper for me. Is there any idea when the next release will be made?

@rashidpathiyil
Copy link

rashidpathiyil commented Feb 17, 2022

Is there any idea when the next release will be made?

Maybe within few hours 😜 🔝 #11555

@thepurpleblob
Copy link

Is there any idea when the next release will be made?

Maybe within few hours 😜 🔝 #11555

Good answer :-D

@rijkvanzanten
Copy link
Member

@thepurpleblob @rashidpathiyil Every PR that's merged is associated to the Milestone for the release it's in. The milestone has the release date on it 🙂

CleanShot 2022-02-17 at 11 45 39@2x

CleanShot 2022-02-17 at 11 46 09@2x

@thepurpleblob
Copy link

Thanks - but where is this information located?

@rijkvanzanten
Copy link
Member

The first screenshot is from further up this page, the second screenshot is from the milestone you can find under Issues > Milestones here on GitHub: https://github.com/directus/directus/milestones 👍🏻

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't create fields in a Repeater field
5 participants