-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix repeater's extension options not updating when configured #11453
Conversation
Thanks! 👏 |
Thank you ❤️ |
How to install beta version of Directus@next to get the fix instantly ? |
@rashidpathiyil You could build the repo from source (https://docs.directus.io/contributing/running-locally/), but I would highly suggest either sticking on the previous version that didn't have this bug, or waiting until the full release 👍🏻 |
I can't go back to previous version due to cockroachdb bug #11266 so I am waiting.... |
This is a bit of a show-stopper for me. Is there any idea when the next release will be made? |
Maybe within few hours 😜 🔝 #11555 |
Good answer :-D |
@thepurpleblob @rashidpathiyil Every PR that's merged is associated to the Milestone for the release it's in. The milestone has the release date on it 🙂 |
Thanks - but where is this information located? |
The first screenshot is from further up this page, the second screenshot is from the milestone you can find under Issues > Milestones here on GitHub: https://github.com/directus/directus/milestones 👍🏻 |
Fixes #11447
Investigation
The bug occurs due to extension options being
null
(as seen in the bug report errors). Seems like in #10828,@input
was replaced withv-model
here: https://github.com/directus/directus/pull/10828/files#diff-922856f7e4b8d662bef225e06b6c4f096632405eb04f56692933576ab202f3f7L20However the list extension options emits
input
rather thanupdate:modelValue
as seen here:directus/app/src/interfaces/list/options.vue
Line 42 in 232c21e
Hence options are not being updated when configured.
Changes made
Replaced
v-model="optionsValues"
with@input="optionsValues = $event"
to fix the reported issue..Fixed lint warning for
extensionInfo
possibly undefined in:is="`${type}-options-${extensionInfo!.id}`"
.usesCustomComponent
will only be true when extensionInfo has value.Changed emitted
update:model-value
to camelCaseupdate:modelValue
just for consistency as the latter is used throughout the app.