Stalling Sqlite when using cascading foreign contraints #13307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…raints otherwise the transaction pool runs full of knex
azrikahar
changed the title
rijkvanzanten
approved these changes
May 16, 2022
brandnewx
pushed a commit
to brandnewx/directus
that referenced
this pull request
May 17, 2022
* Fix directus#10462: Stalling Sqlite when using cascading foreign contraints otherwise the transaction pool runs full of knex * make linter happy
brandnewx
added a commit
to brandnewx/directus
that referenced
this pull request
May 17, 2022
* New translations en-US.yaml (Japanese) (directus#13324) * New translations en-US.yaml (Catalan) (directus#13325) * fix app docs collection & item page (directus#13316) * Stalling Sqlite when using cascading foreign contraints (directus#13307) * Fix directus#10462: Stalling Sqlite when using cascading foreign contraints otherwise the transaction pool runs full of knex * make linter happy * improved clarity of logical operators explanation (directus#13327) * Allow creating big integer auto-incremented primary keys in MySQL and PostgreSQL (directus#13301) * Prevent changing active status of last admin user (directus#13309) * Delete CODEOWNERS Prefer assigning reviewers on a case by case, than have me auto-assigned everywhere all the time * New Crowdin updates (directus#13328) * Update source file en-US.yaml * New translations en-US.yaml (Catalan) * New translations en-US.yaml (Italian) * New translations en-US.yaml (French, Canada) * New translations en-US.yaml (Italian) (directus#13330) * New translations en-US.yaml (Catalan) (directus#13332) * replaced video (directus#13333) * New translations en-US.yaml (Catalan) (directus#13335) * Fix docs homepage sidebar (directus#13270) * Fix docs homepage sidebar * Update progress indicator's color * Apply style to homepage sidebar only * Set different progress indicator color for light mode * Fix inconsistent revisions after batch update (directus#13250) * Sort keys to ensure order * Set query limit as the number of keys * Add query limit only when reading by keys * Update test * Check if keys is of array type * New translations en-US.yaml (Catalan) (directus#13336) * New Crowdin updates (directus#13340) * New translations en-US.yaml (French) * New translations en-US.yaml (Polish) Co-authored-by: Rijk van Zanten <rijkvanzanten@me.com> Co-authored-by: Azri Kahar <42867097+azrikahar@users.noreply.github.com> Co-authored-by: eikaramba <eikaramba@users.noreply.github.com> Co-authored-by: Eron Donevan Powell <62306630+erondpowell@users.noreply.github.com> Co-authored-by: Samuele Zolfanelli <samdazel@gmail.com> Co-authored-by: ian <licitdev@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10462
otherwise the transaction pool of knex runs full. reusing the knex transaction/connection fixes it.