Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add collection and folder names to delete confirmation messages #13610

Merged
merged 3 commits into from
May 31, 2022

Conversation

sxsws
Copy link

@sxsws sxsws commented May 29, 2022

Adding collection and folder names to delete confirmation messages. #13473

Only updated English translation files, so could do with a little help in other languages!

@sxsws sxsws marked this pull request as ready for review May 29, 2022 12:58
@sxsws
Copy link
Author

sxsws commented May 31, 2022

Should I update the non-English translations for the confirmation messages with the folder and collection name at the start of the translation? e.g.
delete_folder_are_you_sure: {collection}: ...Translation of "Do you want to delete this collection?"...

This way, at least the translations have the benefit of the folder/collection name without needing to be updated.

@rijkvanzanten
Copy link
Member

Should I update the non-English translations for the confirmation messages with the folder and collection name at the start of the translation? e.g.

No, that's OK. The other languages will fallback to English while being translated into the appropriate messages through https://locales.directus.io 👍🏻

@sxsws
Copy link
Author

sxsws commented May 31, 2022

But aren't I right in thinking that if a translation is already set for a language, it will use that instead of the fallback? And the existing translations don't have the collection / folder name

@rijkvanzanten
Copy link
Member

Existing translations will be removed / auto updated where available when a key is changed 👍🏻

@sxsws
Copy link
Author

sxsws commented May 31, 2022

oh nice!

@rijkvanzanten rijkvanzanten enabled auto-merge (squash) May 31, 2022 13:59
@rijkvanzanten rijkvanzanten merged commit 6a4a82f into directus:main May 31, 2022
@sxsws sxsws deleted the names-to-confirmation-13473 branch May 31, 2022 14:05
@azrikahar azrikahar changed the title add collection and folder names to delete confirmation messages #13473 add collection and folder names to delete confirmation messages Jun 2, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants