Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix redudant message in unexpected error #15520

Conversation

VincentKempers
Copy link
Member

@VincentKempers VincentKempers commented Sep 11, 2022

Description

I couldn't really reproduce the error in this unexpected-error.vue, but this is about the message itself.

The message in the unexpected-error.vue was redundant as the code and error message are already shown.

Fixes #14972

Type of Change

  • Bugfix
  • Improvement
  • New Feature
  • Refactor / codestyle updates
  • Other, please describe:

Requirements Checklist

  • New / updated tests are included
  • All tests are passing locally
  • Performed a self-review of the submitted code

If adding a new feature:

  • Documentation was added/updated

@VincentKempers VincentKempers changed the title redudant message in unexpected error fix redudant message in unexpected error Sep 11, 2022
@rijkvanzanten rijkvanzanten self-assigned this Sep 11, 2022
@rijkvanzanten rijkvanzanten added this to the Next Release milestone Sep 11, 2022
@rijkvanzanten rijkvanzanten enabled auto-merge (squash) September 11, 2022 15:03
@rijkvanzanten rijkvanzanten merged commit 5f3f44a into directus:main Sep 11, 2022
@azrikahar
Copy link
Contributor

The message in the unexpected-error.vue was redundant as the code and error message are already shown.

Hi! Can you share what was the scenario in your test which still yields error message in the dialog?

Been noticing it showing a blank dialog for Unexpected Error now (not sure about other errors yet), which seems abit odd.

Before After
Dialog shown chrome_BV2oWVhqNC chrome_HMe2yJ9tzU
Value in store chrome_LTAqcdc3R9 chrome_TwnLx0OG37

@rijkvanzanten
Copy link
Member

@azrikahar message was rendered as the second line in that card, and then rendered again in the v-error component as part of the error. The idea of this pr was to remove the line "in the middle" between the title and the v-error component. That being said, the v-error component itself should still be rendered, so that's a new bug

qborisb pushed a commit to qborisb/directus that referenced this pull request Sep 16, 2022
qborisb pushed a commit to qborisb/directus that referenced this pull request Sep 16, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Translation missing : error You don't have permission to access this.
3 participants