Showing the v-error on unexpected errors #15579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rijkvanzanten
approved these changes
Sep 14, 2022
azrikahar
approved these changes
Sep 15, 2022
There was a problem hiding this comment.
@VincentKempers thanks for the fix, not your bad at all! I was mostly wondering the expected outcome in #15520 to make sure I understood it correctly, but Rijk summed it up nicely over here: #15520 (comment)
LGTM!
qborisb
pushed a commit
to qborisb/directus
that referenced
this pull request
Sep 16, 2022
qborisb
pushed a commit
to qborisb/directus
that referenced
this pull request
Sep 16, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
add a check if there is a
notification.textor annotification.errorFollow up from pr #15520
@azrikahar ❤️ my bad
Type of Change
Requirements Checklist
If adding a new feature: