Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Write full item to revisions #17729

Merged
merged 3 commits into from
Mar 9, 2023
Merged

Write full item to revisions #17729

merged 3 commits into from
Mar 9, 2023

Conversation

Nitwel
Copy link
Member

@Nitwel Nitwel commented Mar 7, 2023 •
edited
Loading

Problem: Changes after hooks don't get saved to revisions.

Right now I went with the changes after hooks but we could go even further and also include payloadWithoutAliases which is the data that get's inserted into the table. @rijkvanzanten you very likely know what's the right way here.

Fixes #17677

@Nitwel Nitwel requested a review from a team March 7, 2023 14:31
@Nitwel Nitwel self-assigned this Mar 7, 2023
@Nitwel Nitwel requested review from freekrai, paescuj and jaads and removed request for a team March 7, 2023 14:31
@rijkvanzanten rijkvanzanten self-requested a review March 7, 2023 15:21
paescuj
paescuj approved these changes Mar 9, 2023
View reviewed changes
Copy link
Member

@paescuj paescuj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Considering the data we had before with payload I think payloadAfterHooks is just fine 👍

@rijkvanzanten rijkvanzanten merged commit bbb387f into main Mar 9, 2023
@rijkvanzanten rijkvanzanten deleted the fix-17677 branch March 9, 2023 20:50
@ananth3087
Copy link

@Nitwel @rijkvanzanten could you please let me know the Directus version in which this fix will be available?

@rijkvanzanten
Copy link
Member

@Nitwel @rijkvanzanten could you please let me know the Directus version in which this fix will be available?

The next one 👍🏻

@licitdev licitdev added this to the Next Release milestone Mar 13, 2023
paescuj added a commit that referenced this pull request Mar 14, 2023
@Nitwel @paescuj @rijkvanzanten
Write full item to revisions (#17729)
daf35ef 
* Write full item to revisions

* Get revision data/delta in single call

---------

Co-authored-by: Pascal Jufer <pascal-jufer@bluewin.ch>
Co-authored-by: Rijk van Zanten <rijkvanzanten@me.com>
@ananth3087
Copy link

@Nitwel @rijkvanzanten could you please let me know the Directus version in which this fix will be available?

The next one 👍🏻

@rijkvanzanten could you please create new Directus version (9.23.2) with all latest fixes? i'm waiting for this fix

@paescuj
Copy link
Member

paescuj commented Mar 15, 2023

@Nitwel @rijkvanzanten could you please let me know the Directus version in which this fix will be available?

The next one 👍🏻

@rijkvanzanten could you please create new Directus version (9.23.2) with all latest fixes? i'm waiting for this fix

We can not provide estimates on the timeline for upcoming releases. Thanks for the understanding!

meditadvisors pushed a commit to ciso360ai/directus-mod that referenced this pull request May 13, 2023
@Nitwel @paescuj
@rijkvanzanten @faustro
Write full item to revisions (directus#17729)
c7c9c3e 
* Write full item to revisions

* Get revision data/delta in single call

---------

Co-authored-by: Pascal Jufer <pascal-jufer@bluewin.ch>
Co-authored-by: Rijk van Zanten <rijkvanzanten@me.com>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@paescuj paescuj paescuj approved these changes

@rijkvanzanten rijkvanzanten rijkvanzanten approved these changes

@freekrai freekrai Awaiting requested review from freekrai

@jaads jaads Awaiting requested review from jaads

Assignees

@Nitwel Nitwel

Labels
Bug
Projects
None yet
Milestone
v9.23.2
Development

Successfully merging this pull request may close these issues.

Directus | Flows are not updating the Revision while creating a collection
5 participants
@Nitwel @ananth3087 @rijkvanzanten @paescuj @licitdev