Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translation string performance #18097

Merged
merged 106 commits into from
May 26, 2023
Merged

Conversation

br41nslug
Copy link
Member

@br41nslug br41nslug commented Apr 7, 2023

Rework of #17094

This PR adds the following:

  • A migration to update the current translation_strings content to a new core table.
  • Replaced the hydration of translation strings to only fetch the current language.
  • Updated the translation strings setting page to use the new structure.

Todo

  • Docs

Fixes #15501
Fixes ENG-193

@br41nslug br41nslug changed the title Rework/translation string performance Translation string performance Apr 7, 2023
@changeset-bot
Copy link

changeset-bot bot commented May 12, 2023

🦋 Changeset detected

Latest commit: 46d399c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
@directus/app Minor
@directus/api Minor
@directus/types Minor
directus Patch
@directus/extensions-sdk Patch
create-directus-extension Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@br41nslug br41nslug requested a review from licitdev May 12, 2023 18:31
@br41nslug br41nslug marked this pull request as ready for review May 12, 2023 18:32
app/src/lang/refresh-current-language.ts Outdated Show resolved Hide resolved
.changeset/tender-trees-buy.md Outdated Show resolved Hide resolved
docs/reference/system/translations.md Outdated Show resolved Hide resolved
docs/reference/system/translations.md Outdated Show resolved Hide resolved
api/src/services/translations.ts Outdated Show resolved Hide resolved
@rijkvanzanten rijkvanzanten self-assigned this May 26, 2023
@rijkvanzanten rijkvanzanten merged commit f96dcc3 into main May 26, 2023
@rijkvanzanten rijkvanzanten deleted the rework/translation-string-performance branch May 26, 2023 16:35
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Translation string performance
6 participants