Properly paginate on flow logs #18652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rijkvanzanten
requested review from
a team,
paescuj,
licitdev and
azrikahar
and removed request for
a team
🦋 Changeset detectedLatest commit: f3fb1da The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
licitdev
approved these changes
May 19, 2023
licitdev
reviewed
May 19, 2023
app/src/modules/settings/routes/flows/components/logs-sidebar-detail.vue
Show resolved
Hide resolved
Co-authored-by: Azri Kahar <42867097+azrikahar@users.noreply.github.com>
rijkvanzanten
deleted the
rijk/eng-881-crash-when-too-much-revision-data-linked
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduces the number of revisions loaded per page, and adds pagination support to the flow logs to prevent large sets of revisions to cause memory allocation issues.
Fixes ENG-881