-
-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Properly paginate on flow logs #18652
Properly paginate on flow logs #18652
Conversation
🦋 Changeset detectedLatest commit: f3fb1da The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
app/src/modules/settings/routes/flows/components/logs-sidebar-detail.vue
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Co-authored-by: Azri Kahar <42867097+azrikahar@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM as well ❤️
Reduces the number of revisions loaded per page, and adds pagination support to the flow logs to prevent large sets of revisions to cause memory allocation issues.
Fixes ENG-881