Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some improvements on german translation #1917

Merged
merged 5 commits into from Oct 19, 2017

Conversation

airbenich
Copy link

No description provided.

@@ -534,7 +534,7 @@
"help": "Hilfe",
"submit": "Absenden",
"write_comment": "Kommentar schreiben...",
"new_item": "Neuer Eintrag",
"new_item": "neu",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having nue only is better than "new item"?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@airbenich ping

@airbenich
Copy link
Author

„Neuer Eintrag“ breaks the design. German words and sentences are always long compared to english.

@wellingguzman
Copy link

Thanks @airbenich! I was just wondering the reason :) that makes sense.

@wellingguzman wellingguzman merged commit 2659fc5 into directus:master Oct 19, 2017
@rijkvanzanten
Copy link
Member

@wellingguzman We probably should checkout the design reason btw, I'm pretty sure this problem happens in Dutch as well

@wellingguzman
Copy link

@rijkvanzanten Flexible width layouts? (probably same with Spanish too)

@rijkvanzanten
Copy link
Member

Yes please. I don't know what happened exactly, but some button probably got a max-width it shouldn't have. It's not something we go in and fix for everything now, but it's a good thing to remind this issue the next time we add max-width: $too-small; to the CSS somewhere :)

@wellingguzman
Copy link

Somehow we gotta have a max-width either way, otherwise a text can mess up the layout.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants