-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug Fix] utils/url.js removing trailing slashes #19210
Conversation
Added relevant test cases. See issue directus#19207 IMPORTANT: An existing test fails: https://github.com/directus/directus/blob/c2c04734f0c5e1fa72090c5ca624fcb32d4cf3c9/api/src/utils/url.test.ts#L17
Url() now preserves trailing slashes, including root domains.
🦋 Changeset detectedLatest commit: 3f5fd9b The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@amerkay Thanks for the PR! 👍
Co-authored-by: Pascal Jufer <pascal-jufer@bluewin.ch>
Co-authored-by: Pascal Jufer <pascal-jufer@bluewin.ch>
Hi!
TLDR;
Url("https://example.com/verify/").toString()
returnshttps://example.com/verify
, it removes the trailing slash. It should preserve it. This PR fixes that.utils/url.js
removing trailing slashes #19207Cheers!
Fixes #19207