Fix URL seralizing of trailing slashes after adding paths #19252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 0eda15c The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
paescuj
requested review from
a team,
rijkvanzanten and
azrikahar
and removed request for
a team
paescuj
commented
Jul 26, 2023
|
Whoooops cc @amerkay 😄 |
rijkvanzanten
approved these changes
Jul 26, 2023
br-rafaelbarros
pushed a commit
to personal-forks/directus-source
that referenced
this pull request
Nov 7, 2023
…9252) * Fix URL seralizing of trailing slashes after adding paths * Create rare-shrimps-rescue.md * Clean-up * More precise changeset summary
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19250
Bug introduced with #19210, which missed the recheck for trailing slashes when using the
addPathmethod.Extensions rely on this util to compute the URL of shared deps:
directus/api/src/extensions.ts
Line 411 in 373cc9f
Since the
PUBLIC_URLdefaults to/,depUrlalways ended up with a trailing slash while actually intended to point to a file.