-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Authentication fixes for the SDK #19354
Conversation
…to sdk-fixes-3
🦋 Changeset detectedLatest commit: 30bad9d The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good , besides the little comment 👍
Co-authored-by: Pascal Jufer <pascal-jufer@bluewin.ch>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR LGTM! Just a quick question regarding the breaking-changes.md
, do we need to mention/include the renaming of asSearch
to withSearch
as well?
Yes we do, nice catch |
Co-authored-by: Pascal Jufer <pascal-jufer@bluewin.ch>
Co-authored-by: Pascal Jufer <pascal-jufer@bluewin.ch>
Co-authored-by: Pascal Jufer <pascal-jufer@bluewin.ch>
fetch
(fixes SDK 11: It's impossible to include credentials with AuthenticationClient methods #19344 )asSearch
towithSearch
for consistency.Same-origin cookies:
fetch
does out of the boxCross-origin cookies:
credentials: 'include'
on the appropriate composables to send cookies with all requests on that composablewithOptions
helperNote: Make sure to double check your CORS and CSP settings when working with cross-origin cookies.