Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass file-id down so that FilesService can replace asset upon URL import #19788

Merged
merged 3 commits into from
Sep 25, 2023

Conversation

DanielBiegler
Copy link
Contributor

@DanielBiegler DanielBiegler commented Sep 25, 2023

fix #19785

Before

Screencast.from.25.09.2023.11.03.59.webm

After

Screencast.from.25.09.2023.12.29.01.webm

@DanielBiegler DanielBiegler requested a review from a team September 25, 2023 10:21
@DanielBiegler DanielBiegler self-assigned this Sep 25, 2023
@DanielBiegler DanielBiegler requested review from br41nslug, jaads and azrikahar and removed request for a team September 25, 2023 10:21
@changeset-bot
Copy link

changeset-bot bot commented Sep 25, 2023

🦋 Changeset detected

Latest commit: 618bd68

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@directus/app Patch
@directus/api Patch
directus Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@DanielBiegler DanielBiegler changed the title Pass id down so that FilesService can replace asset upon import Pass file-id down so that FilesService can replace asset upon import Sep 25, 2023
@DanielBiegler DanielBiegler changed the title Pass file-id down so that FilesService can replace asset upon import Pass file-id down so that FilesService can replace asset upon URL import Sep 25, 2023
Copy link
Member

@paescuj paescuj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 🚀

@paescuj paescuj merged commit 8374a9a into main Sep 25, 2023
7 checks passed
@paescuj paescuj deleted the fix-19785-replace-file-with-import-url branch September 25, 2023 11:23
@github-actions github-actions bot added this to the Next Release milestone Sep 25, 2023
br-rafaelbarros pushed a commit to personal-forks/directus-source that referenced this pull request Nov 7, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using a URL to replace an asset doesnt replace said asset, but adds it as a new one
2 participants