Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to import files with predefined ids #20301

Merged
merged 2 commits into from
Nov 2, 2023
Merged

Unable to import files with predefined ids #20301

merged 2 commits into from
Nov 2, 2023

Conversation

br41nslug
Copy link
Member

@br41nslug br41nslug commented Nov 2, 2023

Fixes #20294

Scope

What's changed:

A small fix for the regression introduced in #19788 . Checks for the existence of the file in the database instead of updating solely based on the the presence of a primaryKey.

Review Notes / Questions

  • I would like to lorem ipsum

Copy link

changeset-bot bot commented Nov 2, 2023

🦋 Changeset detected

Latest commit: 3628316

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@directus/api Patch
directus Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@br41nslug br41nslug requested review from a team, jaads and DanielBiegler and removed request for a team and jaads November 2, 2023 11:37
Copy link
Contributor

@DanielBiegler DanielBiegler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in multiple ways. Everything worked for me! 👍

@DanielBiegler DanielBiegler merged commit a09a45e into main Nov 2, 2023
6 checks passed
@DanielBiegler DanielBiegler deleted the fix-20294 branch November 2, 2023 12:53
@github-actions github-actions bot added this to the Next Patch Release milestone Nov 2, 2023
br-rafaelbarros pushed a commit to personal-forks/directus-source that referenced this pull request Nov 7, 2023
* Add check for existing file

* Create five-balloons-drum.md
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regression: Unable to import files with predefined ids
2 participants