-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated Public Page Artwork #20309
Updated Public Page Artwork #20309
Conversation
🦋 Changeset detectedLatest commit: 4f884fd The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Love the design, but.... it runs very inefficiently 😬 CleanShot.2023-11-02.at.16.26.00.mp4 |
@rijkvanzanten — ok, back to you! It's nice and speedy now (afaict) |
* from rainbow to lava lamp * svg paths to divs for performance * Clean up styles * Public view themable options * Make speed themable * Add changeset --------- Co-authored-by: Rijk van Zanten <rijkvanzanten@me.com>
* main: (165 commits) Fix search height Don't try linting yaml files (directus#20366) All incoming code is through PRs Only run CI against files that changed (directus#20365) Show package version if available (directus#20303) Allow overriding asset presets (directus#20305) Refactor variables (directus#20329) Prevent re-installation of deps in Docker image (directus#20346) Use the collection icon in the DrawerItem (directus#20354) Preserve minimal app permissions/validations when merging (directus#20347) rename to `articles` to match other examples (directus#20359) Delete files based on "filename_disk" (directus#20341) SDK translation schema update (directus#20344) Update assign-next-release-milestone.yml Fix disabled input's border color (directus#20340) Fix select all logic in v-field-list-item component (directus#20315) Allow overriding the form elements on the public page (directus#20326) Use server store for public theme information (directus#20324) Updated Public Page Artwork (directus#20309) Updated all docs examples from "@directus/sdk/rest" to "@directus/sdk" (directus#20321) ... # Conflicts: # app/src/lang/translations/de-DE.yaml # app/src/lang/translations/en-US.yaml
@benhaynes If I have my Chrome without hardware acceleration, I get a very choppy page which has a 1-2 second delay while I'm typing my login info. Is there a way to only enable this if hardware acceleration is turned on? It looks fine when I have it on. Specs: |
@ched-dev — not sure about the conditional (does that check exist?) but if the animation isn't running smoothly then I guess the next best thing would be to override it with a public page background image instead. You could even use a screenshot of the animation if you wanted the same vibe. We tried to keep the animation super performant, but it's hard to plan for all hardware/configs. |
Scope
What's changed:
Potential Risks / Drawbacks
Review Notes / Questions
Fixes #20322