Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Public Page Artwork #20309

Merged
merged 8 commits into from
Nov 3, 2023
Merged

Updated Public Page Artwork #20309

merged 8 commits into from
Nov 3, 2023

Conversation

benhaynes
Copy link
Sponsor Member

@benhaynes benhaynes commented Nov 2, 2023

Scope

What's changed:

  • Changed the CSS/design of the art on the public page

Potential Risks / Drawbacks

  • Inefficient use of browser/GPU
  • Subjective design

Review Notes / Questions

  • Efficient enough?
  • Looking good?

Fixes #20322

Copy link

changeset-bot bot commented Nov 2, 2023

🦋 Changeset detected

Latest commit: 4f884fd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@directus/themes Minor
@directus/app Minor
@directus/api Patch
directus Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@rijkvanzanten
Copy link
Member

Love the design, but.... it runs very inefficiently 😬

CleanShot.2023-11-02.at.16.26.00.mp4

@benhaynes
Copy link
Sponsor Member Author

@rijkvanzanten — ok, back to you! It's nice and speedy now (afaict)

@rijkvanzanten rijkvanzanten merged commit 3faab8d into main Nov 3, 2023
5 checks passed
@rijkvanzanten rijkvanzanten deleted the updated-public-art branch November 3, 2023 19:17
@github-actions github-actions bot added this to the Next Patch Release milestone Nov 3, 2023
br-rafaelbarros pushed a commit to personal-forks/directus-source that referenced this pull request Nov 7, 2023
* from rainbow to lava lamp

* svg paths to divs for performance

* Clean up styles

* Public view themable options

* Make speed themable

* Add changeset

---------

Co-authored-by: Rijk van Zanten <rijkvanzanten@me.com>
bvolz added a commit to bvolz/directus that referenced this pull request Nov 9, 2023
* main: (165 commits)
  Fix search height
  Don't try linting yaml files (directus#20366)
  All incoming code is through PRs
  Only run CI against files that changed (directus#20365)
  Show package version if available (directus#20303)
  Allow overriding asset presets (directus#20305)
  Refactor variables (directus#20329)
  Prevent re-installation of deps in Docker image (directus#20346)
  Use the collection icon in the DrawerItem (directus#20354)
  Preserve minimal app permissions/validations when merging (directus#20347)
  rename to `articles` to match other examples (directus#20359)
  Delete files based on "filename_disk" (directus#20341)
  SDK translation schema update (directus#20344)
  Update assign-next-release-milestone.yml
  Fix disabled input's border color (directus#20340)
  Fix select all logic in v-field-list-item component (directus#20315)
  Allow overriding the form elements on the public page (directus#20326)
  Use server store for public theme information (directus#20324)
  Updated Public Page Artwork (directus#20309)
  Updated all docs examples from "@directus/sdk/rest" to "@directus/sdk" (directus#20321)
  ...

# Conflicts:
#	app/src/lang/translations/de-DE.yaml
#	app/src/lang/translations/en-US.yaml
@ched-dev
Copy link
Contributor

@benhaynes If I have my Chrome without hardware acceleration, I get a very choppy page which has a 1-2 second delay while I'm typing my login info. Is there a way to only enable this if hardware acceleration is turned on? It looks fine when I have it on.

Specs:
I'm on an M1 Mac in Chrome Version 120.0.6099.234 (Official Build) (arm64), issue was with hardware acceleration turned off.

@benhaynes
Copy link
Sponsor Member Author

@ched-dev — not sure about the conditional (does that check exist?) but if the animation isn't running smoothly then I guess the next best thing would be to override it with a public page background image instead. You could even use a screenshot of the animation if you wanted the same vibe.

We tried to keep the animation super performant, but it's hard to plan for all hardware/configs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace public page default art
3 participants