Fix select all logic in v-field-list-item component #20315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azrikahar
requested review from
a team and
rijkvanzanten
and removed request for
a team
🦋 Changeset detectedLatest commit: 2354f0d The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
br-rafaelbarros
pushed a commit
to personal-forks/directus-source
that referenced
this pull request
Nov 7, 2023
bvolz
added a commit
to bvolz/directus
that referenced
this pull request
Nov 9, 2023
* main: (165 commits) Fix search height Don't try linting yaml files (directus#20366) All incoming code is through PRs Only run CI against files that changed (directus#20365) Show package version if available (directus#20303) Allow overriding asset presets (directus#20305) Refactor variables (directus#20329) Prevent re-installation of deps in Docker image (directus#20346) Use the collection icon in the DrawerItem (directus#20354) Preserve minimal app permissions/validations when merging (directus#20347) rename to `articles` to match other examples (directus#20359) Delete files based on "filename_disk" (directus#20341) SDK translation schema update (directus#20344) Update assign-next-release-milestone.yml Fix disabled input's border color (directus#20340) Fix select all logic in v-field-list-item component (directus#20315) Allow overriding the form elements on the public page (directus#20326) Use server store for public theme information (directus#20324) Updated Public Page Artwork (directus#20309) Updated all docs examples from "@directus/sdk/rest" to "@directus/sdk" (directus#20321) ... # Conflicts: # app/src/lang/translations/de-DE.yaml # app/src/lang/translations/en-US.yaml
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope
What's changed:
When we are adding fields one by one, we are emitting
field.keyas seen here:directus/app/src/components/v-field-list/v-field-list-item.vue
Line 132 in 4a36355
which is accurate and doesn't include groups in it (but still includes related collection if it's a related collection field).
Hence this PR replaces the original select all logic to re-use
field.keyof the children rather than re-constructing it manually.Before
Currently when we add a field one by one, the fields are added as intended. However when we use the
Select Allbutton, fields within groups are being added as if it's a related collection field:chrome_2PWIs0SXx3.mp4
After
chrome_NgRLR2dg5t.mp4
Potential Risks / Drawbacks
Fixes #19567