Fix nested queries with unlimited default limit #22049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 58b71e4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
paescuj
requested review from
a team,
br41nslug and
DanielBiegler
and removed request for
a team
br41nslug
reviewed
Apr 2, 2024
br41nslug
approved these changes
Apr 15, 2024
hanneskuettner
pushed a commit
that referenced
this pull request
Apr 16, 2024
* Fix nested queries with unlimited default limit * Add changeset
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope
Fix an issue where nested items would not be returned with default query limit of unlimited (
QUERY_LIMIT_DEFAULT=-1).Potential Risks / Drawbacks
None
Review Notes / Questions
ifstatement for slicing wasn't accounting for the value ofQUERY_LIMIT_DEFAULTof-1Fixes #22038