Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

system-filter: Prevent text wrap, and keep field list dropdown for functions #22426

Merged
merged 2 commits into from
May 8, 2024

Conversation

hanneskuettner
Copy link
Member

Scope

Two minor improvements for the system-filter interface:

  • Make sure that long plain names don't wrap:
Before After
Screenshot 2024-05-07 at 11 34 42 Screenshot 2024-05-07 at 11 36 16
  • Handle fields with function names the same as field names when it comes to dropdown behavior. Previously, fields with function names were not identified as existing fields and only displayed as plain-name and one had to manually remove the filter and re-add it with a different field if a function was selected. Now, it behaves just like a normal field name and shows the dropdown on click.

Screenshot 2024-05-08 at 10 45 39

What's changed:

  • Minor CSS change
  • Extend isExistingField to account for function names in the last key part (which is AFAIK the only part that can have a function?)

Potential Risks / Drawbacks

None

Review Notes / Questions

  • Does this warrant a changeset?

Copy link

changeset-bot bot commented May 8, 2024

🦋 Changeset detected

Latest commit: 75903c6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@directus/app Patch
@directus/api Patch
directus Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@hanneskuettner hanneskuettner changed the title system-filter: Prevent text wrap, and keep field selection dropdown for functions system-filter: Prevent text wrap, and keep field list dropdown for functions May 8, 2024
@paescuj paescuj self-assigned this May 8, 2024
Copy link
Member

@paescuj paescuj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, works now 🥳

@paescuj paescuj enabled auto-merge (squash) May 8, 2024 12:36
@paescuj paescuj merged commit 4d570d8 into main May 8, 2024
4 checks passed
@paescuj paescuj deleted the feat-improve-system-filter branch May 8, 2024 12:39
@github-actions github-actions bot added this to the Next Release milestone May 8, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants