app: fix sort creating items #5484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: When sorting, the relations were assigned to another fresh created items on the related collection Why: It was missing the primary key on nested relation. When the primary key is missing, new item is created. How to fix: Iterate over all fields to request and when nested field is found, append the nested primary key.
joselcvarela
force-pushed
the
fix-sort-creating-items
branch
from
862a14f
to
133ad12
Compare
|
Can I do something in order to merge this? |
rijkvanzanten
approved these changes
May 14, 2021
rijkvanzanten
approved these changes
May 14, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: When sorting, the relations were assigned to
another fresh created items on the related collection
Why: It was missing the primary key on nested relation.
When the primary key is missing, new item is created.
How to fix: Iterate over all fields to request and when nested field
is found, append the nested primary key.