Improve disabled state on the file interface
#6025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* See discussion: #5105 * Still allow downloading the file if the file interface is disabled. * Allow editing the underlying file (as this is possible anyway via the files collection), but do not allow disassociating the current file or setting another file, which is the actual semantic meaning of `disabled` in this context.
rijkvanzanten
approved these changes
Jun 3, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See discussion: Downloading files should be still possible if editing is disabled. #5105
Still allow downloading the file if the file interface is disabled.
Allow editing the underlying file (as this is possible anyway via the
files collection), but do not allow disassociating the current file
or setting another file, which is the actual semantic meaning of
disabledin this context.