Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve disabled state on the file interface #6025

Merged
merged 1 commit into from Jun 3, 2021
Merged

Improve disabled state on the file interface #6025

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
65 changes: 33 additions & 32 deletions app/src/interfaces/file/file.vue
View file
Open in desktop
@@ -1,17 +1,10 @@
<template>
<div class="file">
<v-menu attached :disabled="disabled || loading">
<v-menu attached :disabled="loading">
<template #activator="{ toggle }">
<div>
<v-skeleton-loader type="input" v-if="loading" />
<v-input
v-else
@click="toggle"
readonly
:placeholder="$t('no_file_selected')"
:disabled="disabled"
:value="file && file.title"
>
<v-input v-else @click="toggle" readonly :placeholder="$t('no_file_selected')" :value="file && file.title">
<template #prepend>
<div
class="preview"
Expand All @@ -30,7 +23,13 @@
<template #append>
<template v-if="file">
<v-icon name="open_in_new" class="edit" v-tooltip="$t('edit')" @click.stop="editDrawerActive = true" />
<v-icon class="deselect" name="close" @click.stop="$emit('input', null)" v-tooltip="$t('deselect')" />
<v-icon
v-if="!disabled"
class="deselect"
name="close"
@click.stop="$emit('input', null)"
v-tooltip="$t('deselect')"
/>
</template>
<v-icon v-else name="attach_file" />
</template>
Expand All @@ -45,33 +44,35 @@
<v-list-item-content>{{ $t('download_file') }}</v-list-item-content>
</v-list-item>

<v-divider />
<v-divider v-if="!disabled" />
</template>
<template v-if="!disabled">
<v-list-item @click="activeDialog = 'upload'">
<v-list-item-icon><v-icon name="phonelink" /></v-list-item-icon>
<v-list-item-content>
{{ $t(file ? 'replace_from_device' : 'upload_from_device') }}
</v-list-item-content>
</v-list-item>

<v-list-item @click="activeDialog = 'choose'">
<v-list-item-icon><v-icon name="folder_open" /></v-list-item-icon>
<v-list-item-content>
{{ $t(file ? 'replace_from_library' : 'choose_from_library') }}
</v-list-item-content>
</v-list-item>

<v-list-item @click="activeDialog = 'url'">
<v-list-item-icon><v-icon name="link" /></v-list-item-icon>
<v-list-item-content>
{{ $t(file ? 'replace_from_url' : 'import_from_url') }}
</v-list-item-content>
</v-list-item>
</template>
<v-list-item @click="activeDialog = 'upload'">
<v-list-item-icon><v-icon name="phonelink" /></v-list-item-icon>
<v-list-item-content>
{{ $t(file ? 'replace_from_device' : 'upload_from_device') }}
</v-list-item-content>
</v-list-item>

<v-list-item @click="activeDialog = 'choose'">
<v-list-item-icon><v-icon name="folder_open" /></v-list-item-icon>
<v-list-item-content>
{{ $t(file ? 'replace_from_library' : 'choose_from_library') }}
</v-list-item-content>
</v-list-item>

<v-list-item @click="activeDialog = 'url'">
<v-list-item-icon><v-icon name="link" /></v-list-item-icon>
<v-list-item-content>
{{ $t(file ? 'replace_from_url' : 'import_from_url') }}
</v-list-item-content>
</v-list-item>
</v-list>
</v-menu>

<drawer-item
v-if="!disabled && file"
v-if="file"
:active.sync="editDrawerActive"
collection="directus_files"
:primary-key="file.id"
Expand Down