Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to exifr for image metadata extraction #6922

Merged
merged 4 commits into from
Aug 5, 2021
Merged

Switch to exifr for image metadata extraction #6922

merged 4 commits into from
Aug 5, 2021

Conversation

paescuj
Copy link
Member

@paescuj paescuj commented Jul 22, 2021

Replace outdated exif-reader and icc libraries as well as the util parse-iptc.ts by the exifr library which provides all required functionalities (even more) to extract metadata from images.

Updated version of #6369, including migration (tested).

Remaining questions:

@rijkvanzanten
Copy link
Member

This might fix #7206

@rijkvanzanten
Copy link
Member

Do we really want to extract all the metadata as it has been done before with exif-reader ("interop", "ifd1" aka "thumbnail")?

Yea, the more the better

exifr has two options (translateValues & reviveValues) to translate raw values into more readable values - those are currently turned off to get same result as before with exif-reader. Do we want to keep those options turned off?

Nah raw is fine. These are meant as a backup of the exif data, not a human readable source

Keys of "icc" and "iptc" data were camel case before and are now in pascal case. Do you think this change is acceptable or do we need to migrate those as well?

That's fine 👍🏻

@rijkvanzanten rijkvanzanten merged commit bea3794 into directus:main Aug 5, 2021
@paescuj paescuj deleted the switch-to-exifr-for-image-metadata-extraction branch August 6, 2021 07:08
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants