Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add default preset for webhooks page #8937

Merged
merged 3 commits into from
Oct 19, 2021
Merged

add default preset for webhooks page #8937

merged 3 commits into from
Oct 19, 2021

Conversation

azrikahar
Copy link
Contributor

Not sure does this count as resolving #8913 as presets & roles don't have default presets, but at the same time those two are current non-configurable.

Used the same chips/display setting as actions for methods, but they may be not enough contrast, particularly for light theme.

After

Light

chrome_CrRphAo28v

Dark

chrome_lt4D8tqqz6

@benhaynes
Copy link
Sponsor Member

Looking good!! I think we can remove the URL since it could be super long and the "Name" should be a better descriptor.

Jeez, I can't wait until we support some dynamic options for these Table Layout column widths. Would be nice to have "Fit to content" and "Min/Max width" options.

api/src/database/system-data/fields/webhooks.yaml Outdated Show resolved Hide resolved
app/src/stores/presets.ts Outdated Show resolved Hide resolved
app/src/stores/presets.ts Outdated Show resolved Hide resolved
@rijkvanzanten rijkvanzanten enabled auto-merge (squash) October 19, 2021 15:34
@rijkvanzanten rijkvanzanten added this to the v9.0.0-rc.99 milestone Oct 19, 2021
@rijkvanzanten rijkvanzanten merged commit 2c0b61f into main Oct 19, 2021
@rijkvanzanten rijkvanzanten deleted the issue/8913 branch October 19, 2021 15:39
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants