Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix repeater interface template #9588

Merged
merged 1 commit into from
Nov 9, 2021
Merged

Conversation

azrikahar
Copy link
Contributor

fixes #9587

Context

Previously the logic was "return either props.template or first field":

const templateWithDefaults = computed(() => props.template || `{{${props.fields[0].field}}}`);

However the current logic is props.template became a condition check in #9113:

const templateWithDefaults = computed(() =>
props.template || props.fields?.[0]?.field ? `{{${props.fields[0].field}}}` : ''
);

So we'll need to move props.template back into the if statement body.

@rijkvanzanten rijkvanzanten merged commit b1494e8 into main Nov 9, 2021
@rijkvanzanten rijkvanzanten deleted the fix-repeater-template branch November 9, 2021 15:44
rijkvanzanten pushed a commit that referenced this pull request Dec 1, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Interface Display Template for Repeater doesn't show configured values
2 participants