Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add @NoTransaction to the Press controller #43

Closed
irregular-at opened this issue May 31, 2013 · 4 comments
Closed

Add @NoTransaction to the Press controller #43

irregular-at opened this issue May 31, 2013 · 4 comments

Comments

@irregular-at
Copy link

Hi!

If jpa/a database is configured, then for each request play! gets a connection from the connection pool and starts a transaction. You can read the detailed infos here:
http://www.playframework.com/documentation/1.2.5/jpa#transactions

So I was wondering if the controller handling the press requests (controllers.press.Press) also gets a connections and opens a transaction for each request?
If so I think it makes sense to simply add the @play.db.jpa.NoTransaction Annotation to this controller class, because press never uses any database connection and therefore would unnecessarily fetch and occupy a db connection from the pool. Which also would improve performance.

I'm I right?

Regards,

Matthias

@dirkmc
Copy link
Owner

dirkmc commented Jun 10, 2013

Hi Matthias, sorry for late response, I was on vacation. The play guys are no longer taking updates to plugins for play version 1, so I'm no longer maintaining this plugin. Thanks for checking this out anyway.
Dirk

@irregular-at
Copy link
Author

Hi Dirk,

thanks for your reply.
So does this mean Play 1.2 is not supported anymore? I was thinking Play 1.2 coexists with Version 2...

Matthias

@dirkmc
Copy link
Owner

dirkmc commented Jun 10, 2013

This plugin only works with play 1.x, not with play 2.x. It's no longer possible for me to update the plugin on playframework.org so essentially that means that updates to plugins for play 1.x are no longer supported. I think play 1.x as a whole is still being supported by the play team.
Dirk

@irregular-at
Copy link
Author

Thanks for clarification!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants