Add support for threads #1613

DV8FromTheWorld · 2021-05-01T07:32:27Z

The Threads api is currently in open beta and can only be used in small testing guilds

Currently this encapsulates only the most minimalist pass on being able to construct entities for threads and the happy path of receiving messages in threads.
Only "supports" receiving messages via the GenericMessageEvent and MessageReceivedEvent

This PR will be in a draft state for quite a while and is here for collaboration. Expect incredibly breaking changes as we prepare for threads.

Currently this encapsulates only the most minimalist pass on being able to construct entities for threads and the happy path of recieving messages in threads. Only "supports" receiving messages via the GenericMessageEvent and MessageReceivedEvent

MinnDevelopment · 2021-06-20T16:57:33Z

src/main/java/net/dv8tion/jda/api/entities/ChannelType.java

+    /**
+     * TODO docs | https://discord.com/developers/docs/resources/channel#channel-object-channel-types
+     */
+    GUILD_NEWS_THREAD(10, -1,true), //TODO confirm handling of sort bucket.


It seems like you can't sort threads so this sort bucket value is irrelevant

What even is a news thread anyway?

Suggested change

GUILD_NEWS_THREAD(10, -1,true), //TODO confirm handling of sort bucket.

GUILD_NEWS_THREAD(10, -1, true),

MinnDevelopment · 2021-06-20T16:59:02Z

src/main/java/net/dv8tion/jda/api/entities/GuildThread.java

+    // - getMembers //TODO might not need this as we'll have getThreadMembers()
+
+    //TODO pick a better name (or use getParent once we break from GuildChannel interface?)
+    GuildChannel getParentChannel();


Maybe just MessageChannel getAncestor() for now, you can only create threads on message channels anyway.

MinnDevelopment · 2021-06-20T17:00:39Z

src/main/java/net/dv8tion/jda/api/entities/GuildThread.java

+    int getMemberCount();
+
+    //TODO | This name is bad. Looking for alternatives.
+    boolean isSubscribedToThread();


How about isJoined()?

isJoined sounds, odd to me.

isSubscribed or hasJoined sound better imo

MinnDevelopment · 2021-06-20T17:02:43Z

src/main/java/net/dv8tion/jda/api/entities/MessageType.java

@@ -108,6 +111,11 @@
     */
    GUILD_DISCOVERY_GRACE_PERIOD_FINAL_WARNING(17),

+    /**
+     * TODO docs | https://discord.com/developers/docs/topics/threads#new-message-types


Suggested change

* TODO docs | https://discord.com/developers/docs/topics/threads#new-message-types

* Message which indicates that a {@link net.dv8tion.jda.api.entities.GuildThread GuildThread} has been created.

MinnDevelopment · 2021-06-20T17:03:38Z

src/main/java/net/dv8tion/jda/api/events/message/GenericMessageEvent.java

+        {
+            throw new IllegalStateException("This message was not sent in a guild");
+        }


Suggested change

{

throw new IllegalStateException("This message was not sent in a guild");

}

throw new IllegalStateException("This message was not sent in a guild");

MinnDevelopment · 2021-06-20T17:07:09Z

src/main/java/net/dv8tion/jda/internal/entities/GuildThreadImpl.java

+public class GuildThreadImpl extends AbstractChannelImpl<GuildThread, GuildThreadImpl> implements GuildThread
+{
+    //TODO this same pattern is used in MemberImpl. Might want to consider centralizing? dunno.
+    private static final ZoneOffset OFFSET = ZoneOffset.of("+00:00");


We could move this to Helpers

MinnDevelopment · 2021-06-20T17:07:31Z

src/main/java/net/dv8tion/jda/internal/entities/GuildThreadImpl.java

+    @Override
+    public int getPosition()
+    {
+        throw new UnsupportedOperationException("Thread do not have a concept of position");


How does the client order them? Can we not just use the same ordering?

It is either based on join date or creation date. Will need to test, but yeah, it does have an implicit ordering. That being said, it isn't an explicit one and it would change when you leave/join threads, so I'm really on the fence about supporting this.

Really this method only exists on threads because of the interfaces implemented. Providing a position here doesn't make sense especially since position historically implies something that you can modify like with other channels. There's no actionable information for bots here.

MinnDevelopment · 2021-06-20T17:07:56Z

src/main/java/net/dv8tion/jda/internal/entities/GuildThreadMemberImpl.java

@@ -0,0 +1,107 @@
+package net.dv8tion.jda.internal.entities;


MinnDevelopment · 2021-06-20T17:08:29Z

src/main/java/net/dv8tion/jda/internal/entities/GuildThreadMemberImpl.java

+        return this;
+    }
+
+    GuildThreadMemberImpl setFlags(long flags)


Should these be public?

MinnDevelopment · 2021-06-20T17:08:48Z

src/main/java/net/dv8tion/jda/internal/entities/ReceivedMessage.java

+        {
+            throw new IllegalStateException("This message was not sent in a guild");
+        }


Suggested change

{

throw new IllegalStateException("This message was not sent in a guild");

}

throw new IllegalStateException("This message was not sent in a guild");

# Conflicts: # src/main/java/net/dv8tion/jda/internal/entities/EntityBuilder.java

Tais993 · 2021-07-02T18:31:15Z

src/main/java/net/dv8tion/jda/api/entities/GuildThread.java

+    @Nullable
+    String getArchivingMemberId();
+
+    long getArchivingMemberIdLong();


When I receive a THREAD_UPDATE event it doesn't include the member who archived the channel. (I've the GUILD_MEMBERS intent)
Am I misunderstanding what this method is supposed to do or?

You would get this information regardless of the GUILD_MEMBERS intent. However, this property can be null (for the String version) or 0 (for the long version) when the thread was auto-archived by Discord based on inactivity duration.

{ "op" : 0, "s" : 8, "t" : "THREAD_UPDATE", "d" : { "last_message_id" : "860587045402968105", "audience" : { "parent_id" : "859388924278734868", "channel_type" : 11 }, "parent_id" : "859388924278734868", "owner_id" : "823709352509833256", "name" : "wa", "guild_id" : "859165430752870400", "thread_metadata" : { "archived" : true, "archive_timestamp" : "2021-07-02T18:25:43.757579+00:00", "locked" : true, "auto_archive_duration" : 1440 }, "id" : "859390106968129587", "type" : 11, "member_count" : 2, "message_count" : 8 }

When manually archiving a thread, am I doing something wrong or missing something? (using latest features/threads branch)

@DV8FromTheWorld I'm probably doing something wrong, but just bumping it to make sure.

rainbowdashlabs · 2021-08-25T17:02:45Z

Is there a checklist whats missing here?
I really heavily rely on this PR and I would offer my help If someone is willing to provide some minimal checklist of whats still need to be done here.

Artuto · 2021-09-03T17:30:50Z

Are there any updates on this? Discord is forcefulling enabling threads on all guilds on 9/9 and JDA still doesn't support them (which is bad for moderation and logging bots).

Tais993 · 2021-09-03T17:55:41Z

Threads require changes to the channel hierarchy to be properly implemented, so they'll be JDA 5
For updates I'd say join the Discord and check the (archived) threads within the libdev channel.
Also, check the v5 branch.

DV8FromTheWorld · 2021-09-08T14:40:34Z

This PR isn't what we're going to move forward with for Threads in JDA.
Threads will be reimplemented on top of the changes made in the v5 branch.

I'm hoping to publish a list of "what needs to happen to get to Threads" soon.

We've been in a transitionary period for the project, moving from having a single core developer to trying to move to more community involvement, but that comes with some bumps along the way. Threads have not been forgotten.

DV8FromTheWorld · 2021-11-30T00:26:16Z

JDA v5.0.0-alpha.1 is released and has support for threads.
https://github.com/DV8FromTheWorld/JDA/releases/tag/v5.0.0-alpha.1

Started work on threads

60b2b0a

Currently this encapsulates only the most minimalist pass on being able to construct entities for threads and the happy path of recieving messages in threads. Only "supports" receiving messages via the GenericMessageEvent and MessageReceivedEvent

DV8FromTheWorld mentioned this pull request May 1, 2021

Implement support for the upcoming Threads #1611

Closed

3 tasks

MinnDevelopment reviewed Jun 20, 2021

View reviewed changes

Merge remote-tracking branch 'origin/development' into feature/threads

a85ca7e

# Conflicts: # src/main/java/net/dv8tion/jda/internal/entities/EntityBuilder.java

Tais993 reviewed Jul 2, 2021

View reviewed changes

Phoenix616 mentioned this pull request Jul 27, 2021

Support threads zachbr/Dis4IRC#58

Open

rainbowdashlabs mentioned this pull request Jul 28, 2021

Implement Support for Threads rainbowdashlabs/reputation-bot#138

Closed

qixils mentioned this pull request Aug 20, 2021

Threads in Support category ProjectEdenGG/Issues#783

Closed

Dinty1 mentioned this pull request Aug 31, 2021

Threads Support DiscordSRV/DiscordSRV#1217

Open

DV8FromTheWorld closed this Nov 30, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for threads #1613

Add support for threads #1613

DV8FromTheWorld commented May 1, 2021 •

edited by MinnDevelopment

Loading

MinnDevelopment Jun 20, 2021

MinnDevelopment Jun 20, 2021

DV8FromTheWorld Jun 29, 2021

MinnDevelopment Jun 20, 2021

MinnDevelopment Jun 20, 2021

Tais993 Aug 1, 2021

MinnDevelopment Jun 20, 2021

MinnDevelopment Jun 20, 2021

MinnDevelopment Jun 20, 2021

MinnDevelopment Jun 20, 2021

DV8FromTheWorld Jun 29, 2021 •

edited

Loading

MinnDevelopment Jun 20, 2021

MinnDevelopment Jun 20, 2021

MinnDevelopment Jun 20, 2021

Tais993 Jul 2, 2021

DV8FromTheWorld Jul 2, 2021

Tais993 Jul 3, 2021

Tais993 Jul 6, 2021

rainbowdashlabs commented Aug 25, 2021

Artuto commented Sep 3, 2021

Tais993 commented Sep 3, 2021

DV8FromTheWorld commented Sep 8, 2021 •

edited

Loading

DV8FromTheWorld commented Nov 30, 2021

	GUILD_NEWS_THREAD(10, -1,true), //TODO confirm handling of sort bucket.
	GUILD_NEWS_THREAD(10, -1, true),

	* TODO docs \| https://discord.com/developers/docs/topics/threads#new-message-types
	* Message which indicates that a {@link net.dv8tion.jda.api.entities.GuildThread GuildThread} has been created.

Add support for threads #1613

Add support for threads #1613

Conversation

DV8FromTheWorld commented May 1, 2021 • edited by MinnDevelopment Loading

The Threads api is currently in open beta and can only be used in small testing guilds

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

DV8FromTheWorld Jun 29, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rainbowdashlabs commented Aug 25, 2021

Artuto commented Sep 3, 2021

Tais993 commented Sep 3, 2021

DV8FromTheWorld commented Sep 8, 2021 • edited Loading

DV8FromTheWorld commented Nov 30, 2021

DV8FromTheWorld commented May 1, 2021 •

edited by MinnDevelopment

Loading

DV8FromTheWorld Jun 29, 2021 •

edited

Loading

DV8FromTheWorld commented Sep 8, 2021 •

edited

Loading