Task/accessibility alt text #2115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let me rebase this when I get to a PC, only just realised there are conflicts |
ghost
marked this pull request as draft
Fixed several bits of broken formatting, a bunch of NBSP characters that are not used elsewhere, and fixed a few broken code examples (missing semi-colons, et cetera). Added a table describing the example of the Rich Presence activity example, since it is not clear to users who have impaired sight as to how this may look. This is added in response to #2097 (comment) on PR #2097 by Mason.
ghost
marked this pull request as ready for review
|
@tpcstld cherry-picked the commit, not sure why the history was completely different to the history when I branched off of the feature branch, but it should be good to go now if you still want to merge it 👍 |
tpcstld
approved these changes
Oct 1, 2020
|
Thanks btw! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #2106, @tpcstld fyi :)