Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added alt text to images, moved GitHub CDN-hosted images into repo. #2106

Closed
wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Sep 26, 2020

Fixed several bits of broken formatting, a bunch of NBSP characters
that are not used elsewhere, and fixed a few broken code examples
(missing semi-colons, et cetera).

Added a table describing the example of the Rich Presence activity
example, since it is not clear to users who have impaired sight as to
how this may look.

This is added in response to #2097 (comment) on PR #2097 by Mason.

Put this up to go into the feature/api-gateway-v8 so that it does not immediately
have conflicts with all the other content that has been changed dotted around.

Fixed several bits of broken formatting, a bunch of NBSP characters
that are not used elsewhere, and fixed a few broken code examples
(missing semi-colons, et cetera).

Added a table describing the example of the Rich Presence activity
example, since it is not clear to users who have impaired sight as to
how this may look.

This is added in response to
#2097 (comment)
on PR #2097 by Mason.
@ghost ghost mentioned this pull request Sep 26, 2020
5 tasks
@msciotti msciotti closed this Sep 29, 2020
@ghost
Copy link
Author

ghost commented Sep 30, 2020

@msciotti was there a reason this got closed, out of curiosity?

@tpcstld
Copy link
Contributor

tpcstld commented Sep 30, 2020

I think it might have been a side effect of the branch being deleted :blobsweat:

It's late now I'll poke tomorrow.

@ghost
Copy link
Author

ghost commented Sep 30, 2020

cheers :)

@tpcstld
Copy link
Contributor

tpcstld commented Sep 30, 2020

Err yeah. So I can't seem to reopen this PR cuz the base branch is deleted. Is there a chance you could change it to point at master? Then I'll merge this in.

@ghost ghost mentioned this pull request Oct 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants