Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(APIApplicationCommand): add channel_types field to channel options #198

Merged
merged 11 commits into from
Oct 3, 2021

Conversation

suneettipirneni
Copy link
Member

@suneettipirneni suneettipirneni commented Sep 16, 2021

Please describe the changes this PR makes and why it should be merged:

Adds the channel_types option to command options that use channel selection.

Reference Discord API Docs PRs or commits:

Copy link
Member

@vladfrangu vladfrangu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small change needed, as well as running the deno hooks, otherwise LGTM

@vladfrangu
Copy link
Member

Please let the build:deno script/hook do the deno changes 🙏

@suneettipirneni
Copy link
Member Author

Ohhh that's automated... should I revert my last commit?

@vladfrangu
Copy link
Member

vladfrangu commented Sep 16, 2021 via email

@suneettipirneni
Copy link
Member Author

PR has been merged upstream

Copy link
Member

@vladfrangu vladfrangu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

v8 pls

Copy link
Member

@vladfrangu vladfrangu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In payloads/v8/_interactions/_applicationCommands/chatInput.ts, you forgot to remove line 16

@vladfrangu vladfrangu changed the title Add channel_types field to channel options in application commands. feat(APIApplicationCommand): add channel_types field to channel options Oct 3, 2021
@vladfrangu vladfrangu merged commit 77396b5 into discordjs:main Oct 3, 2021
@suneettipirneni suneettipirneni deleted the typings/channel-type branch October 6, 2021 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants