Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embeds on CommandInteraction.editReply #10111

Closed
Protected opened this issue Feb 1, 2024 · 2 comments
Closed

Embeds on CommandInteraction.editReply #10111

Protected opened this issue Feb 1, 2024 · 2 comments

Comments

@Protected
Copy link

Which application or package is this feature request for?

discord.js

Feature

According to the API documentation, the Edit Original Interaction Response endpoint supports the same options as the Edit Webhook Message endpoint. If that is true, that means it should currently support editing embeds in the original interaction response.

However, InteractionEditReplyOptions doesn't currently allow for embeds, only attachments (InteractionReplyOptions allows for embeds). Attempting to pass a list of embeds with the options or attempting to pass the embed directly to the method results in exceptions.

I'm not currently working with Webhooks directly, but glancing at the documentation for discord.js it looks as though they might have the same issue?

Ideal solution or implementation

It would be great if embed editing was added to editReply, much like it's already possible for regular Messages.

I think this should be accomplished by adding an "embeds" field to InteractionEditReplyOptions, which would function as it does in the other methods that take a list of embeds.

Alternative solutions or implementations

No response

Other context

No response

@Jiralite
Copy link
Member

Jiralite commented Feb 1, 2024

However, InteractionEditReplyOptions doesn't currently allow for embeds, only attachments (InteractionReplyOptions allows for embeds). Attempting to pass a list of embeds with the options or attempting to pass the embed directly to the method results in exceptions.

Share the error, code, versions applicable, etc.

@Protected
Copy link
Author

Sorry, I thought this was a feature request. You're right, there was a mistake in the code. This new documentation is quite difficult to parse and I didn't spot the embeds option several levels down.

@Jiralite Jiralite closed this as not planned Won't fix, can't repro, duplicate, stale Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants