fix(GuildMemberManager): options.roles on 'prune' #4838
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since 257371d was merged, it allowed an array of values to be passed through a query's value (as explained here). f1194af did not accommodate for these changes that were committed beforehand to make
include_roles=foo&include_roles=bar
possible.As of discord/discord-api-docs@b9edace#diff-c4e1390fca89ecc96b01a093f988fa1cR720 Discord now accepts a "comma-delimited array of snowflakes"... but the old
key=value&key=value
still works (and is even being used in the client). This PR changes the prune method to pass comma-delimited array of role IDs foroptions.roles
since that is what is currently documented. The code within theAPIRequest
class hasn't been changed for more compatibility (incase Discord decides to add or change another query that accepts thekey=value&key=value
format).compute_prune_count
is also excluded from the GET request for the prune in this PR, since that isn't being used.Fixes #4834
Here's a snippet of how I tested these changes
Status
Semantic versioning classification: