feat(Message): add messageEditHistoryMaxSize to limit stored msg edits #4867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MattIPv4
force-pushed
the
limit-message-edit-history
branch
from
b6b9043
to
d002113
Compare
MattIPv4
changed the title
tguichaoua
suggested changes
Sep 30, 2020
MattIPv4
force-pushed
the
limit-message-edit-history
branch
from
d002113
to
4c70dc3
Compare
kyranet
approved these changes
Sep 30, 2020
vladfrangu
approved these changes
Sep 30, 2020
izexi
reviewed
Sep 30, 2020
MattIPv4
force-pushed
the
limit-message-edit-history
branch
3 times, most recently
from
361f525
to
14f079d
Compare
kyranet
reviewed
Sep 30, 2020
BannerBomb
reviewed
Oct 1, 2020
MattIPv4
force-pushed
the
limit-message-edit-history
branch
from
14f079d
to
4967a2b
Compare
izexi
approved these changes
Oct 1, 2020
MattIPv4
force-pushed
the
limit-message-edit-history
branch
from
4967a2b
to
fffe3d0
Compare
The messageEditHistoryMaxSize client option sets a hard limit for the maximum number of previous versions held in a message when it gets edited.
MattIPv4
force-pushed
the
limit-message-edit-history
branch
from
fffe3d0
to
22b2e70
Compare
|
Fixed the issue with messageUpdate not firing by changing Message#patch to return the old message clone, which can then be used when the event is fired. Method is private, so I assume this can remain minor. |
SpaceEEC
approved these changes
Oct 13, 2020
izexi
reviewed
Oct 16, 2020
MattIPv4
force-pushed
the
limit-message-edit-history
branch
from
22b2e70
to
2c725a4
Compare
iCrawl
approved these changes
Oct 17, 2020
GiorgioBrux
pushed a commit
to GiorgioBrux/discord.js
that referenced
this pull request
Oct 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
This fixes #4826 by adding a new client option to set a fixed limit on the edit history stored for each message in the client cache.
This has been tested in production on my bot (where the original memory issue was observed) for roughly a month and seems to be fine.
Status
Semantic versioning classification: